On Mon, Aug 17, 2015 at 12:42 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> - if (type & (FILTER_REFS_ALL | FILTER_REFS_INCLUDE_BROKEN)) >> - ret = for_each_rawref(ref_filter_handler, &ref_cbdata); >> - else if (type & FILTER_REFS_ALL) >> - ret = for_each_ref(ref_filter_handler, &ref_cbdata); >> - else if (type) >> + if (type & FILTER_REFS_INCLUDE_BROKEN) { >> + type -= FILTER_REFS_INCLUDE_BROKEN; > > The above is a somewhat unusual way to say the more idiomatic: > > type &= ~FILTER_REFS_INCLUDE_BROKEN; > > when dealing with bit flags. Is there precedence elsewhere in the > project for choosing '-' over '~'? s/precedence/precedent/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html