On Fri, Aug 14, 2015 at 3:18 PM, Sven Strickroth <sven@xxxxxxxxxx> wrote:
> Without this patch there might be open handle leaks.
Thanks for the patch. A question below...
> Signed-off-by: Sup Yut Sum <ch3cooli@xxxxxxxxx>
> Signed-off-by: Sven Strickroth <email@xxxxxxxxxx>
> ---
> diff --git a/config.c b/config.c
> index 9fd275f..89b49e3 100644
> --- a/config.c
> +++ b/config.c
> @@ -2048,6 +2048,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
> if ((store.seen == 0 && value == NULL) ||
> (store.seen > 1 && multi_replace == 0)) {
> ret = CONFIG_NOTHING_SET;
> + close(in_fd);
> goto out_free;
>From a cursory read of the code, it appears that there are several
other places where the open 'in_fd' gets leaked which would deserve
the same treatment. So, it's not clear why this patch handles only
this one case. Am I missing something?
> }
>
> --
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html