Karthik Nayak <karthik.188@xxxxxxxxx> writes: > get_ref_atom_value(info, parse_ref_filter_atom(sp + 2, ep), &atomv); > - format_quote_value(atomv, quote_style, &output); > + set_formatting_state(atomv, &state); > + format_quote_value(atomv, &state); > + perform_state_formatting(&state, &final_buf); > } > if (*cp) { > sp = cp + strlen(cp); > - append_non_atom(cp, sp, &output); > + append_non_atom(cp, sp, &state); > + perform_state_formatting(&state, &final_buf); > } With the two helpers being very sketchy at this stage, it is very hard to judge if they make sense. At the conceptual level, I can see that set-formatting-state is to allow an atom to affect the state before the value of the atom is emitted into the buffer. I cannot tell what perform-state-formatting is meant to do from these call sites. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html