Jeff King <peff@xxxxxxxx> writes: > The problem is that git_path uses a static buffer that gets overwritten > by subsequent calls. As the rotating static buffer pattern used in get_pathname() was modeled after sha1_to_hex(), we have the same issue there. They are troubles waiting to happen unless the callers are careful. > producing a fairly tame-looking set of function calls. It's OK to pass > the result of git_path() to a system call, or something that is a thin > wrapper around one (e.g., strbuf_read_file). That is a short and good rule to follow, but the problem is that not everybody has good taste to interpret the above rule and apply it with an eye toward maintainability X-<. > Along the way, there are a few cleanups (e.g., I polished off the recent > hold_lock_file_for_append topic which was on the list, as it had some > problematic calls). > > [01/17]: cache.h: clarify documentation for git_path, et al > [02/17]: cache.h: complete set of git_path_submodule helpers > [03/17]: t5700: modernize style > [04/17]: add_to_alternates_file: don't add duplicate entries > [05/17]: remove hold_lock_file_for_append > [06/17]: prefer git_pathdup to git_path in some possibly-dangerous cases > [07/17]: prefer mkpathdup to mkpath in assignments > [08/17]: remote.c: drop extraneous local variable from migrate_file > [09/17]: refs.c: remove extra git_path calls from read_loose refs > [10/17]: path.c: drop git_path_submodule > [11/17]: refs.c: simplify strbufs in reflog setup and writing > [12/17]: refs.c: avoid repeated git_path calls in rename_tmp_log > [13/17]: refs.c: avoid git_path assignment in lock_ref_sha1_basic > [14/17]: refs.c: remove_empty_directories can take a strbuf > [15/17]: find_hook: keep our own static buffer > [16/17]: get_repo_path: refactor path-allocation > [17/17]: memoize common git-path "constant" files Nice. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html