Hi Peff,
On 2015-08-10 07:23, Jeff King wrote:
> diff --git a/compat/pipe-id.c b/compat/pipe-id.c
> new file mode 100644
> index 0000000..4764c5f
> --- /dev/null
> +++ b/compat/pipe-id.c
> @@ -0,0 +1,25 @@
> +#include "git-compat-util.h"
> +#include "compat/pipe-id.h"
> +#include "strbuf.h"
> +
> +const char *pipe_id_get(int fd)
> +{
> + static struct strbuf id = STRBUF_INIT;
> + struct stat st;
> +
> + if (fstat(fd, &st) < 0 || !S_ISFIFO(st.st_mode))
> + return NULL;
Just a quick note: it seems that this check is not really working on Windows. I tested this by running this test case manually (because TTY is not set on Windows):
> +test_expect_success TTY 'no color when paged program writes to pipe' '
> + test_config alias.externallog "!git log | cat >log.out" &&
> + test_config color.ui auto &&
> + test_terminal env TERM=vt100 git -p externallog &&
> + test_line_count = 0 paginated.out &&
> + test -s log.out &&
> + ! colorful log.out
> +'
The output is "colorful" ;-)
I hope to find some time tomorrow to figure out some workaround that makes this work on Windows.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html