On Thu, Aug 06, 2015 at 02:18:26PM -0400, Eric Sunshine wrote: > However, that begs the question: Why do you need argv_array_copy() at > all? Isn't the same functionality already provided by > argv_array_pushv()? To wit, a caller which wants to copy from 'src' to > 'dst' can already do: > > struct argv_array src = ...; > struct argv_array dst = ARGV_ARRAY_INIT; > argv_array_pushv(&dst, src->argv); Thanks for reviewing this, Eric. Everything you said is exactly what I was thinking, too, especially this last part. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html