Re: [PATCH v3] remote: add get-url subcommand

[Ben Boeckel <mathstuf@xxxxxxxxx>]

On Wed, Aug 05, 2015 at 13:34:18 -0700, Junio C Hamano wrote:
> Changes to these two files look reasonable.
> 
> Don't you want to protect this feature from future breakage by
> others by adding a couple of tests, though, to t/t5505?

Thanks, I've done so locally. It actually brings up this case:

    $ git remote add someremote foo
    $ git remote get-url --push someremote
    fatal: no URLs configured for remote 'someremote'

Is it better to use:

    remote = remote_get(remotename);
    remote->pushurl;

    if (remote->pushurl_nr)
        remote->pushurl;
    else
        remote->url;

or:

    remote = pushremote_get(remotename);
    remote->pushurl;

? What is the actual difference between the two?

Thanks,

--Ben
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html