Thank you for your reply. Your t8919 test case looks exactly like the right thing. Unfortuantly I don’t have Internet access for the next two weeks. Afterwards I will provide a proper test cases for the patch. You are correct about the speed. All these initial “p4 dirs” calls make the clone pretty slow. However, for us it is a one time history migration and therefore speed is not an issue. I also understand your “core.ignorecase” comment. Let’s assume the path correction works as expected, how and when would you trigger it? Would you only rely on the “server ignoring case” flag? Cheers, Lars On 05 Aug 2015, at 00:06, Luke Diamand <luke@xxxxxxxxxxx> wrote: > On 02/08/15 16:15, larsxschneider@xxxxxxxxx wrote: >> From: Lars Schneider <larsxschneider@xxxxxxxxx> >> >> Hi, >> >> I want to propose this patch as it helped us to migrate a big source code base >> successfully from P4 to Git. I am sorry that I don't provide a test case, yet. > > Case sensitivity is a pretty tricky area with p4 - it's very brave of you to have a go at fixing it! > >> I would like to get advise on the patch and on the best strategy to provide a >> test. Do you only run git-p4 integration tests in "t/t98??-git-p4-*.sh"? If yes, >> which version of "start_p4d" should I use? > > Only the t98* tests relate to git-p4 so if you just copy one of those it should do the right thing. > > t9819-git-p4-case-folding.sh already has a few failing tests for this problem. I wrote it a while back just to illustrate the problem, so it might be of use to you, or you might need to start again. > > Won't your change make importing much slower for people with this problem? > > Also, I'm not sure you can use "core.ignorecase" to trigger this: the problem will arise if the *server* is ignoring case as well (which I think you can detect by querying the server). > > I'm not trying to be negative - but this problem does have some annoying pitfalls! Let me know if you think I can help though. > > Regards! > Luke > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html