Re: [PATCH 2/5] diff --quiet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, 14 Mar 2007, Junio C Hamano wrote:

> "Alex Riesen" <raa.lkml@xxxxxxxxx> writes:
> 
> > Now I'm happy :)
> >
> > ~/linux$ time git diff-tree -r -s v2.6.16 v2.6.20
> >
> > real    0m0.137s
> > user    0m0.117s
> > sys     0m0.020s
> > ~/linux$ time ~/projects/git-diff/git-diff-tree -r --quiet v2.6.16 v2.6.20
> >
> > real    0m0.006s
> > user    0m0.000s
> > sys     0m0.007s
> 
> You do not need diff-tree --quiet to do that!
> 
> 	$ git-rev-parse v2.6.16^{tree} v2.6.20^{tree}

Well, if you have a path-spec, it can certainly matter.

Personally, I think it's more interesting if this can make a difference 
for something like

	git log v2.6.12.. -- drivers/ > /dev/null

but that would require that we actually understand that we can stop early 
if we ever get to REV_TREE_DIFFERENT. I didn't check if you actually did 
that optimization.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]