Re: [RFC/PATCH] Port branch.c to use ref-filter APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 28, 2015 at 11:23 PM, Matthieu Moy
<Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
> Karthik Nayak <karthik.188@xxxxxxxxx> writes:
>
>> On Tue, Jul 28, 2015 at 7:05 PM, Matthieu Moy
>> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
>>
>>> Ideally, you could also have a modifier atom %(alignleft) [...]
>>
>> This could work for refname, as each ref_array_item holds the refname,
>> But other atoms are only filled in after a call to
>> verify_ref_format().
>
> If you swap the order and call verify_ref_format() after filter_refs(),
> then you could detect %(alignleft) and iterate over the list as needed
> in verify_ref_format().
>
> (You would actually force swapping the order and you would need to adapt
> other callers in for-each-ref and tag)
>
>> But I don't see this as priority for now, so will mark it off for later.
>
> Absolutely, that's what I meant by "Ideally". I'm just thinking aloud.
>

Maybe after GSoC ;-)

-- 
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]