On Tue, Jul 28, 2015 at 9:13 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Karthik Nayak <karthik.188@xxxxxxxxx> writes: > >> From: Karthik Nayak <karthik.188@xxxxxxxxx> >> >> Add support for %(objectname:size=X) where X is a number. >> This will print the first X characters of an objectname. >> The minimum value for X is 5. Hence any value lesser than >> 5 will default to 5 characters. > > Is the reason why you do not call this "abbrev" because you are > allowing it to truncate to a non-unique prefix? > > If so, wouldn't it make more sense to treat this kind of string > function in a way very similar to your earlier "padright"? I.e. > "%(maxwidth:5)%(objectname)" or something? > > If not, and if this is really an abbrev, then it makes sense to make > it specific to the objectname, e.g. "%(objectname:abbrev=7)". It is finding unique abbrev, I just named size as it was smaller. But abbrev seems better, will rename, thanks :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html