On Tue, Jul 28, 2015 at 12:17 AM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Karthik Nayak <karthik.188@xxxxxxxxx> writes: > >> On Mon, Jul 27, 2015 at 9:24 PM, Matthieu Moy >> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >>> Yes, but on the other hand we already have: >>> >>> git log --format='%<|(50)A very long irrevlevancy|%an|' >>> >>> that pads/truncate %an. So, consistancy would dictate that Karthik's >>> version is the right one. >> >> Sorry but I didn't understand what you're trying to say here, Matthieu. > > The "git log" equivalent of %(padright:N) is %<|(N), and it behaves the > same way as your current implementation of %(padright) (except for the > missing reset in your v5). > > So, if we want to be consistant with "git log", we should keep the > "apply to next atom, even if it's far away in the format string" > semantics. > > Note that consistancy is not the only criterion for choice, so I'm not > saying we should absolutely do this, just that there's an argument in > favor of it. > I didn't know that, thanks, I think I'll let Junio make the call here :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html