Karthik Nayak <karthik.188@xxxxxxxxx> writes: > On Mon, Jul 27, 2015 at 9:27 PM, Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> On Mon, Jul 27, 2015 at 6:24 PM, Matthieu Moy >> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >>> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >>> >>>> --- a/ref-filter.c >>>> +++ b/ref-filter.c >>>> @@ -946,6 +946,32 @@ static int commit_contains(struct ref_filter *filter, struct commit *commit) >>> >>>> +/* >>>> + * Return 1 if the refname matches one of the patterns, otherwise 0. >>>> * A pattern can be path prefix (e.g. a refname "refs/heads/master" >>>> * matches a pattern "refs/heads/") or a wildcard (e.g. the same ref >>>> * matches "refs/heads/m*",too). >>> >>> Nit: you used to s/,too/, too/ in the comment in a previous version. >>> >> >> That's carried over from a previous patch, ill change it. >> >>> I think I already suggested saying explicitly "... matches a pattern >>> "refs/heads/" but not "refs/heads/m")", but I won't insist on that. Just >>> a reminder in case you missed it. >>> >> >> Sorry, I missed that out. Thanks for reminding. >> > > If I remember right, I didn't change that cause It didn't pertain to > this commit. I forgot to mention it in your previous mail. The "but not "refs/heads/m"" part makes sense in this patch to document explicitly the difference with the other function. But again, it's just a suggestion, you chose whether to apply it or not. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html