Karthik Nayak <karthik.188@xxxxxxxxx> writes:
> On Sun, Jul 26, 2015 at 4:10 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
>> Without looking at the callers, s->version looks like a misdesign
>> that should be updated to use the same cmp_type mechanism? That
>> would lead to even more obvious construct that is easy to enhance,
>> i.e.
>>
>> switch (cmp_type) {
>> case CMP_VERSION:
>> ...
>> case CMP_STRING:
>> ...
>> case CMP_NUMBER:
>> ...
>> }
>>
>> I dunno.
>>
>> Other than that (and the structure of that "format-state" stuff we
>> discussed separately), the series was a pleasant read.
>>
>> Thanks.
>
> That was the previous design, but Duy asked me to do this so
> that we could support all atoms. And I agree with him on this.
>
> http://article.gmane.org/gmane.comp.version-control.git/273888
I am not objecting, but $gmane/273888 does not immediately read, at
least to me, as suggesting using a mechanism different from cmp_type
but a dedicated field s->version. Puzzled...
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html