From: Jacob Keller <jacob.keller@xxxxxxxxx> As per Junio's suggestion, break cleanup/fix and new functionality into separate patches. Also update description of the new functionality. The first patch is entirely cleanup of comments with no functionality change at all (indeed only changes to comment text!). It now correctly highlights all characters which are disallowed. Discovered by creating a test function that printed out the whole list. The second patch introduces the new functionality for "*" and details how it is now checked per-component. It also explains how the flags are now passed as a pointer so that we can reject any multi-"*" reference, by clearing the REFNAME_REFSPEC_PATTERN bit. Change since v4 - split the cleanup to a separate patch and included all missing values from the disposition "4" on the comments. Jacob Keller (2): refs: cleanup comments regarding check_refname_component refs: loosen restriction on wildcard "*" refspecs Documentation/git-check-ref-format.txt | 4 ++-- refs.c | 44 +++++++++++++++++++--------------- refs.h | 4 ++-- t/t1402-check-ref-format.sh | 8 ++++--- 4 files changed, 34 insertions(+), 26 deletions(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html