Re: [PATCH v9 6/7] update-ref and tag: add --create-reflog arg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/21/2015 09:42 AM, Junio C Hamano wrote:
> David Turner <dturner@xxxxxxxxxxxxxxxx> writes:
> 
>> diff --git a/builtin/update-ref.c b/builtin/update-ref.c
>> index 6763cf1..d9646ef 100644
>> --- a/builtin/update-ref.c
>> +++ b/builtin/update-ref.c
>> @@ -14,6 +14,7 @@ static const char * const git_update_ref_usage[] = {
>>  
>>  static char line_termination = '\n';
>>  static int update_flags;
>> +int create_reflog_flag;
> 
> No need to reroll only for this, but I'll s/^int/static &/; while
> queuing.
> 
> I may have more comments later; this was found in the first pass.

In fact, this variable is used as the "flags" argument to
ref_transaction_create(), so it should be

    s/^int/static unsigned &/

Michael

-- 
Michael Haggerty
mhagger@xxxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]