On Mon, Jul 20, 2015 at 5:32 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sat, Jul 18, 2015 at 3:12 PM, Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> In 'tag.c' we can print N lines from the annotation of the tag using >> the '-n<num>' option. Copy code from 'tag.c' to 'ref-filter' and >> modify 'ref-filter' to support printing of N lines from the annotation >> of tags. >> >> Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx> >> --- >> diff --git a/ref-filter.c b/ref-filter.c >> index 771c48d..82731ac 100644 >> --- a/ref-filter.c >> +++ b/ref-filter.c >> @@ -1288,7 +1288,48 @@ static void assign_formating(struct ref_array_item *ref, int parsed_atom, struct >> } >> } >> >> -void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style) >> +/* Print 'lines' no of lines of a given oid */ > > This is difficult to read and understand. I presume you meant "no." as > shorthand for "number" but dropped the period. Even with the period, > it's still hard to read. Perhaps rewrite it as: > > If 'lines' is greater than 0, print that may lines of... > > or something. > Ah okay :) Will change it to a better explanation. >> diff --git a/ref-filter.h b/ref-filter.h >> index c18781b..7dfdea0 100644 >> --- a/ref-filter.h >> +++ b/ref-filter.h >> @@ -87,8 +88,11 @@ int parse_ref_filter_atom(const char *atom, const char *ep); >> int verify_ref_format(const char *format); >> /* Sort the given ref_array as per the ref_sorting provided */ >> void ref_array_sort(struct ref_sorting *sort, struct ref_array *array); >> -/* Print the ref using the given format and quote_style */ >> -void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style); >> +/* >> + * Print the ref using the given format and quote_style. If lines > 0, >> + * prints the "lines" no of lines of the objected pointed to. >> + */ > > Same problem. This literal "no" is quite confusing. Perhaps rewrite as above: > > If lines > 0, print that many lines of... Will change this too. > >> +void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style, unsigned int lines); > > ref-filter.h seems to be setting a precedent for overlong lines. > Wrapping this manually could improve readability. > Definitely! Thanks for all the suggestions. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html