Re: [PATCH] Allow git-diff exit with codes similar to diff(1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 13 Mar 2007, Linus Torvalds wrote:

> On Wed, 14 Mar 2007, Johannes Schindelin wrote:
> > 
> > So, big master to hom everybody bows, how to return the correct value 
> > when executing a pager? Because this _has_ to be done if we go that 
> > way.
> 
> Why? If you execute the pager, nobody cares about the error value 
> anyway.
> 
> I don't see why you would mix in a pager here. If you do
> 
> 	diff -u file1 file2 | less -S
> 
> the return value of the pipe will not only generally be totally 
> uninteresting and never used, but it will be the return value of "less" 
> anyway. Which is what we'd get quite naturally.

The thing is, most people do not realize that

	git diff file1 file2

_will_ execute a pager. As foreground process. And the return value is 
that of the pager.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]