Paul Tan <pyokagan@xxxxxxxxx> writes: >> However, I am reluctant to blindly replace assert(!state->field) >> with free(state->field). Are there cases where we _must_ call a >> function that sets these fields at most once? > > I wouldn't say we are "blindly" replacing them. I said "I was", not "you and me". If there was a case where we should never call into a codepath once these fields are already initialized, then we need to keep assert(!state->field) in such a codepath. I didn't know if that were the case, hence I would have been blindly replacing, which I didn't want to do. And that is why I asked _you_ ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html