On Fri, Jul 10, 2015 at 9:50 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > This may be enough to support the various existing formats that are > offered by "git branch" and/or "git tag", but I do not think if this > is the right approach in the longer term, or if we are painting > ourselves in a corner we cannot cleanly get out of later [*1*]. > Will the "refname" stay to be the only thing that may want alignment > padding appended in the future? Will it stay true that we want to > align only to the left? Etc., etc. > > Cc'ed Duy as %< in the pretty-format was his invention at around > a5752342 (pretty: support padding placeholders, %< %> and %><, > 2013-04-19). > I kinda had the same though, my only justification was that it was only being internally used. I'll have another look if as to see if I can make it universal somehow. Let's see what Duy has to suggest. > > When adding a new thing to an existing list, we prefer to append it > at the end of the list, if there is no other reason not to do so > (e.g. "the existing list is sorted in this order, and the new > location was chosen to fit the new item to honor the existing > ordering rule" is a valid reason to put it at the beginning, if the > existing sorting rule dictates that the new thing must come at the > beginning). > my bad, will change it! > > In newer code, we would want to avoid atoi() so that "foo:shortalign=1z" > that is a typo of "12" can be caught as an error. Either strtol_i() > or strtoul_ui() may be better (we would need to adjust it further > when Michael decides to resurrect his numparse thing that has been > in the stalled bin for quite a while, though). > Will have a look, thanks :) > > What should happen when the display column width of the string is > wider? If a user wants to align the refs that are usually usually > short start the next thing at the 8th column, which should she use? > > "%(refname:shorta=7) %(next item)" > "%(refname:shorta=8)%(next item)" > Both your examples would start the next item at the 8th column (starting with 0), the only difference being : Case 1: when the refname is 8 columns wide "%(refname:shorta=7) %(next item)": would give us eight columns of refname + space + next item "%(refname:shorta=8)%(next item)": would give us eight columns of refname + next item Case 2: when the refname < 8 columns wide Both would give: upto 7 columns of refname + space + next item. Thanks for the suggestions :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html