Re: [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Karthik Nayak <karthik.188@xxxxxxxxx> writes:

> On Wed, Jul 8, 2015 at 2:37 PM, Matthieu Moy
> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
>> Torsten Bögershausen <tboegi@xxxxxx> writes:
>>
>>> Could we have a tweak for people without gpg?
>>
>> I guess we need stg like
>>
>> if ! test_have_prereq GPG; then
>>         skip_all='skipping for-each-ref tests, gpg not available'
>>         test_done
>> fi
>>
>> since we need GPG in the setup test and almost all other tests will rely
>> on it.
>>
>
> Does this need to be there? I see a lot of test files which need GPG, and since
> this test file contains tests which rely on it, without it, it would
> be kinda useless
> anyways?

In many cases, the tests look like

. lib-gpg.sh

test_expect_success 'test that does not use GPG' '
        ...
'

test_expect_success GPG 'test that does use GPG' '
        ...
'

so you can't decide in lib-gpg.sh that you'll skip all tests, because
you would skip some tests that could be ran without gpg.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]