Re: [PATCH 4/4] Replace fork_with_pipe in bundle with run_command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes:

> Junio C Hamano <junkio@xxxxxxx> wrote:
>> "Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes:
>> >  	return status;
>> 
>> As the variable 'status' is not used anymore, I think this should return 0.
>
> Indeed.  I replaced that patch with another (same subject) in my
> latest series.  Because leaving that 'status' variable in caused
> a failure in the test suite when trying to create a bundle.
>
>   fixed:  http://article.gmane.org/gmane.comp.version-control.git/42087
>   borked: http://article.gmane.org/gmane.comp.version-control.git/42056
>
> You quoted the borked one.  Please drop it and apply the fixed one.

Ok, diffing these two the only differences I see are identical
to what I locally hand-fixed, so we are Ok it seems.



-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]