Clemens Buchacher <clemens.buchacher@xxxxxxxxx> writes: > Since e481af06 (rebase: Handle cases where format-patch fails) we > notice if format-patch fails and return immediately from > git-rebase--am. We save the return value with ret=$?, but then we > return $?, which is usually zero in this case. > > Fix this by returning $ret instead. Sounds sensible. > > Cc: Andrew Wong <andrew.kw.w@xxxxxxxxx> > Signed-off-by: Clemens Buchacher <clemens.buchacher@xxxxxxxxx> > Reviewed-by: Jorge Nunes <jorge.nunes@xxxxxxxxx> Where was this review made? I may have missed a recent discussion, and that is why I am asking, because Reviewed-by: lines that cannot be validated by going back to the list archive does not add much value. Thanks. > --- > git-rebase--am.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/git-rebase--am.sh b/git-rebase--am.sh > index f923732..9ae898b 100644 > --- a/git-rebase--am.sh > +++ b/git-rebase--am.sh > @@ -78,7 +78,7 @@ else > > As a result, git cannot rebase them. > EOF > - return $? > + return $ret > fi > > git am $git_am_opt --rebasing --resolvemsg="$resolvemsg" \ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html