On Tue, Jun 30, 2015 at 7:51 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > I needed to read this patch a few times as this patch introduces `sign_commit` > twice. This is mostly a review problem I'd guess as in the code it > just affects this > method and you'd see all the code of the method easily compared to hunks sent > via email. But renaming this variable doesn't hurt. OK. What variable name do you want? Would "gpgsign" (to match commit.gpgsign) do? Regards, Paul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html