On Tue, Jun 30, 2015 at 1:18 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Torsten Bögershausen <tboegi@xxxxxx> writes: >> 2 remarks: >> - I don't know if and why we need the assert() here (but don't know if >> we have a strategie in Git for assert()) > > There is no bright-line rules, but I think it is sensible to remove > this. Nobody sane would throw a NULL at open(2) and xopen() is > supposed to imitate that interface. We do protect ourselves from > careless use of our own API, but no need to clutter the code with > overly zealous check against insane code, I would say. Ah, okay. Will remove these assert()s. Regards, Paul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html