On Tue, 2015-06-30 at 12:48 -0700, Junio C Hamano wrote: > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > > >>> Alternatives would be strbuf_reset() or declaring and releasing the > >>> strbuf within the for-loop scope. > >> > >> Because _reset() just rewinds the .len pointer without deallocating, > >> you would need an extra _release() before it goes out of scope. If > >> it is expected that the strbuf will be reused for a number of times, > >> the length of the string each iteration uses is similar, and you > >> will iterate the loop many times, "_reset() each time and _release() > >> to clean-up" pattern would save many calls to realloc/free. > > > > Yep, that's why I suggested strbuf_reset() as an alternative (and > > likely would have chosen it myself). > > OK, then let's do that by squashing this in. > > builtin/reflog.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I squashed that into my repo on github: https://github.com/dturner-tw/git.git on the branch dturner/pluggable-backends-preamble -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html