On Mon, 12 Mar 2007, Linus Torvalds wrote: > > Otherwise, please apply something like this, which also fixes the return > value. We should return -1 on error! Btw, I didn't remove the if (!commit) break; but I should have. It doesn't actually matter (since it will never trigger), but it adds to the confusion around pop_most_recent_commit. Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html