Re: [PATCH 5/6] git-reflog: add create and exists functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Now, going back to 4/6, I think create_reflog() function as an
> external API has a few problems.
>
>  * Its name does not tell us what should happen when a reflog
>    already exists for the refname the caller asked to "create"
>    reflog for.  I understand that this only makes sure it exists and
>    does not destroy existing one.  Its old name, log_ref_setup(),
>    did not have this problem, but now it does.
> ...
>  * Add a thin-wrapper for callers that do not care about the path to
>    the log file, e.g.
>
> 	int vivify_reflog(const char *refname, struct strbuf *err)
> 	{

As usual, I am aware that I am not good at naming things (but I can
tell when somebody uses a bad name), and "vivify" may be a horrible
name for that.  A reroll with a better name is very much welcomed.

Perhaps prepare-reflog?  I dunno.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]