Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> And instead of die()ing, I'd rather do something like
>
> return (pack_refs || run_command_v_opt(argv_pack_refs, RUN_GIT_CMD) &&
> run_command_v_opt(argv_reflog_expire, RUN_GIT_CMD) &&
> run_command_v_opt(argv_repack, RUN_GIT_CMD) &&
> (prune || run_command_v_opt(argv_prune, RUN_GIT_CMD) &&
> run_command_v_opt(argv_rerere, RUN_GIT_CMD);
Gaaaaaaaah.
That may be valid C, but please do that as a sequence of
separate statements.
if (we are told to pack-refs)
if (try to pack refs and find error)
goto failure;
if (try to reflog expire and find error)
goto failure;
...
return Ok;
failure:
return Error;
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html