Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
> > +test_rebase_end () {
> > + test_when_finished "git checkout master &&
> > + git branch -D $1 &&
> > + test_might_fail git rebase --abort" &&
> > + git checkout -b $1 master
> > +}
>
> The way this is indented makes it difficult to see that lines 2 and 3
> are continuations of 1. Perhaps format it like this instead?
>
> test_rebase_end () {
> test_when_finished "git checkout master &&
> git branch -D $1 &&
> test_might_fail git rebase --abort" &&
> git checkout -b $1 master
> }
I completely agree with you, moreover it was indented like this before.
I'll change it in my local version for now.
Ironically, it was modified after the following:
Galan Rémi <remi.galan-alfonso@xxxxxxxxxxxxxxxxxxxxxxx> writes:
> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
> > > +test_expect_success 'rebase -i respects rebase.missingCommitsCheck=ignore' '
> > > + test_config rebase.missingCommitsCheck ignore &&
> > > + test_when_finished "git checkout master &&
> > > + git branch -D tmp2" &&
> >
> > Strange indentation.
>
> Considering that 'git branch -D tmp2' is a part of test_when_finished,
> I wasn't sure of how it was supposed to be indented, so I did it this
> way to show that it was still within test_when_finished and not a
> separate command.
> > test_when_finished "git checkout master &&
> > git branch -D tmp2" &&
> Doesn't seem as clear, especially if you quickly read the lines.
>
> For now, I have removed the tab.
:p
Thanks,
Rémi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html