Re: [PATCH v2 2/7] bisect: replace hardcoded "bad|good" by variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Antoine Delaite <antoine.delaite@xxxxxxxxxxxxxxxxxxxxxxx> writes:

> Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: 
>
>>Being an acceptable ref name is a constraint you have to check (Junio 
>>already mentionned check-ref-format). I think quoting variables makes 
>>sense too 
>
> I don't get how 'git check-ref-format' works exactly. It says it needs 
> at least one slash in the ref name. So it would not be good for bisect 
> terms.

At some point, refs/bisect/$good and refs/bisect/$bad-$sha1 will become
refs, so you should check refs/bisect/$good and refs/bisect/$bad with
check-ref-format (I think the -$sha1 suffix will be accepted by
construction).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]