Re: [PATCH v6 18/19] fsck: git receive-pack: support excluding objects from fsck'ing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 19, 2015 at 6:35 AM, Johannes Schindelin
<johannes.schindelin@xxxxxx> wrote:
>
> @@ -227,6 +277,10 @@ static int report(struct fsck_options *options, struct object *object,
>         if (msg_type == FSCK_IGNORE)
>                 return 0;
>
> +       if (options->skiplist && object &&
> +                       sha1_array_lookup(options->skiplist, object->sha1) >= 0)
> +               return 0;
> +
>         if (msg_type == FSCK_FATAL)
>                 msg_type = FSCK_ERROR;
>         else if (msg_type == FSCK_INFO)

I just double checked this patch because I wanted to make sure this
was applied in the
report() function (i.e. behave as if FSCK_IGNORE was specified for
specific objects on
the skip list), and I am happy to see that it indeed is the case.

That was because I briefly feared that skip could be done before going
through the usual
verification chain, which would have been very wrong (e.g. we may want
not to hear about
missing tagger in v2.6.11-tree tag, but nevertheless we would want to
check all the tree
contents pointed at by that tag, as that tree may not be reachable by
any other way).

So this one looks good.
--
To unsubscribe from this list: send the line "unsubscribe git" in



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]