Hi Junio, On 2015-06-19 22:18, Junio C Hamano wrote: > Johannes Schindelin <johannes.schindelin@xxxxxx> writes: > >> When fsck_tag() identifies a problem with the commit, it should try >> to make it possible to continue checking the commit object, in case the >> user wants to demote the detected errors to mere warnings. > > I agree with that. But if FSCK_MSG_BAD_OBJECT_SHA1 is an ignorable > error, why should we still have a conditional "goto done" here? > > Shouldn't we be parsing the object the same way regardless? Same reason as I mentioned before: in `git receive-pack --strict` we want to fail early, there is no sense to keep going when we know that nothing of the rest will make it to the server. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in