Re: [PATCH] mergetools: add config option to disable auto-merge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 18, 2015 at 4:43 AM David Aguilar <davvid@xxxxxxxxx> wrote:
>
> On Wed, Jun 17, 2015 at 10:27:58PM -0400, Mike Rappazzo wrote:
> >
> > I feel that the auto-merge takes away the context of the changes.
> >
> > I use araxis merge as my mergetool of choice.  I almost always immediately
> > undo the auto-merge.  After taking a moment to look at each file, I will
> > then (usually) use the keyboard shortcut for auto-merge.
> >
> > It sure would be nice to "set-and-forget" a config variable to remove the
> > annoyance of having to undo the auto-merge.  I think that this config
> > option is reasonable.  Perhaps my documentation leaves something to be
> > desired.  I can take another stab at it.
>
> If this is the case then I would recommend making it more
> granular.  Just because Araxis' automerge is undesirable does
> not mean that some other tools' automerge is as well.
> e.g. the config variable could be "mergetool.<tool>.automerge"
> rather than the top-level "mergetool.automerge" variable.

I don't necessarily think that araxis' automerge is bad, but I like to look
at the before and after to understand the context of a conflict.  I can't
imagine that this is a quirk of araxis, but is probably something that
exists for any auto-merging tool.  The feature doesn't seem to be that
widely supported among the other tooling.  I only found the three to use
such a feature.

Since the automerge option is not available on every merge tool, it seems
reasonable to use "mergetool.<tool>.automerge" instead of "merge.automerge".

>
>
> But, as Junio suggested, having a command-line flag to skip the
> behavior might be a better first step.  Something like,
> "git mergetool --no-automerge".
>
> Most of Git's behavior that can be modified via configuration
> can also be modified on the command-line, so exposing this
> feature as a flag would probably be a good idea.


This makes sense, and if this change is to go forward, I will implement the
command line option.

>
> Even without a config variable, it can still be fire-and-forget
> convenient by using a git alias to supply the flag.
>
> In lieu of any of these features, another option is that you can
> override the default command by setting "mergetool.araxis.cmd",
> and "git mergetool" will use your definition rather than its
> built-in command.  We left that escape hatch in for just this
> purpose.

I guess that if this patch does not go forward, I will have to use this
workaround.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]