Re: [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mike Hommey <mh@xxxxxxxxxxxx> writes:

> I'm tempted to make init_notes itself do the check, based on the value
> it is given for a "read_only" argument.

Yeah, that would be one sensible way to go after making sure that
everything goes thru this interface.

> On the other hand, some commands
> do their ref resolving themselves already.

Again, as long as they do not bypass the "read-only" safety you are
suggesting to add to init_notes(), that is OK.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]