Re: [PATCH] More build output cleaning up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 Mar 2007 00:13:08 +0100 Alex Riesen wrote:

> - print output file name for .c files
> - suppress output of the names of subdirectories when make changes into them
> - use GEN prefix for makefile generation in perl/
>
> Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx>
> ---
>  Makefile      |    8 +++++---
>  perl/Makefile |    2 +-
>  2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 72d4291..eb6c421 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -605,14 +605,16 @@ ifdef NO_PERL_MAKEMAKER
>  	export NO_PERL_MAKEMAKER
>  endif
>  ifndef V
> -	QUIET_CC       = @echo '   ' CC $<;
> +	QUIET_CC       = @echo '   ' CC $@;
>  	QUIET_AR       = @echo '   ' AR $@;
>  	QUIET_LINK     = @echo '   ' LINK $@;
>  	QUIET_BUILT_IN = @echo '   ' BUILTIN $@;
>  	QUIET_GEN      = @echo '   ' GEN $@;
>  	QUIET_SUBDIR0  = @subdir=
> -	QUIET_SUBDIR1  = ;echo '   ' SUBDIR $$subdir; $(MAKE) -C$$subdir
> +	QUIET_SUBDIR1  = ;echo '   ' SUBDIR $$subdir; \
> +			 $(MAKE) --no-print-directory -C $$subdir

Using --no-print-directory will break movement to the location of an
error/warning message at least in vim (emacs will probably have
problems too), if the error is in some file in a subdirectory.  The
problem is that the nested make will output paths relative to the
subdirectory, but without "Entering directory..." messages the editor
will not know that filenames should be interpreted relative to that
subdirectory.

Currently this problem is not visible, because subdirectories with
their own Makefiles (perl/ and git-gui/) do not contain C code - but
the problem will appear, e.g., if Git.xs will be added again.

Attachment: pgpbRF8Eq3qv6.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]