On 3/11/07, Matthias Lederhofer <matled@xxxxxxx> wrote:
Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> wrote: > My case seems a bit complicated than usual. The working directory > (/home/pclouds/blog/data) was not a prefix of cwd (/home/pclouds/blog) > so the code failed silently at this line. If I replace > "has_working_directory = 0; return NULL;" with "strcpy(cwd,gitwd);c = > 0;break;", it may work but see below If you're outside the specifed working directory the is_bare_repository will return true, just as if you don't have a working directory. Do you expect anything else or doesn't this work?
Yes I expected it to move the specified working directory as described in the previous mail (copied/pasted below). However the patch requires me to be in workdir somewhere already (which is fine if that is your expectation). If that's the case, maybe you should tell users something about GIT_WORK_DIR not applicable.
Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> wrote: > By the way, is it plausible to add --git-workdir option to specify > working directory? With that option, I won't need to _chdir_ to the > working directory, run git commands and _chdir back_. http://article.gmane.org/gmane.comp.version-control.git/38382 Since I did not need this feature that much and no one replied that there is any interest I did not look any further into it.
-- Duy - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html