On Mon, Jun 15, 2015 at 11:35 AM, Jeff King <peff@xxxxxxxx> wrote: > > I think the real benefit of naming parameters is that you can talk about > "fn" and "cb_data" by name in the docstring[1]. Yes, I would think it is a very sensible thing to do, if a patch that adds docstring adds names so that the documentation can refer to them. But otherwise, the patch presented here adds only noise without adding much value. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html