On Fri, Jun 12, 2015 at 1:45 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> On Thu, Jun 11, 2015 at 3:21 AM, Paul Tan <pyokagan@xxxxxxxxx> wrote:
>> @@ -138,13 +202,33 @@ static void am_next(struct am_state *state)
>> */
>> static void am_run(struct am_state *state)
>> {
>> - while (state->cur <= state->last)
>> + while (state->cur <= state->last) {
>> +
>> + /* TODO: Patch application not implemented yet */
>> +
>> am_next(state);
>> + }
>
> When reviewing the previous patch I did look at this loop for awhile confused,
> if you want to apply patches in am_next(state) and thought there might be
> a better approach.
>
> Maybe you want to move this chunk with the TODO into the previous patch,
> so it's clear after reading the documentation of am_run, that the actual am is
> missing there.
Ah right, this is a mistake. This comment should be in the previous patch.
Thanks,
Paul
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html