Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: >> + if test -s "$GIT_DIR/TERMS_DEFINED" >> + then >> + terms_defined=1 >> + get_terms >> + rm -rf "$GIT_DIR/TERMS_DEFINED" > >I don't understand why you need to delete this file. I did not review >thoroughly so there may be a reason, but you can help the reader with a >comment here. I will just complete Louis' answer. We delete it with backward compatibility with old/new in mind (even if old/new is not merged yet). For instance, after a old/new mode, if you do a 'bisect start rev1 rev2' the mode would be bad/good ie the default mode. So if you defined your terms, we decided it would only be for the following bisection. The next 'bisect start rev1 rev2' would be in bad/good mode. But this have to be discuted, do the user have to type 'git bisect terms' each bisection if he wants to use special terms ? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html