On Sun, Jun 14, 2015 at 11:19 AM, Christian Couder <christian.couder@xxxxxxxxx> wrote: > On Sat, Jun 13, 2015 at 10:18 PM, Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> >> diff --git a/ref-filter.h b/ref-filter.h >> index c2856b8..799e118 100644 >> --- a/ref-filter.h >> +++ b/ref-filter.h >> @@ -50,6 +50,18 @@ struct ref_filter_cbdata { >> struct ref_filter *filter; >> }; >> >> +/* Macros for checking --merged and --no-merged options */ >> +#define OPT_NO_MERGED(filter, h) \ >> + { OPTION_CALLBACK, 0, "no-merged", (filter), N_("commit"), (h), \ >> + PARSE_OPT_LASTARG_DEFAULT | PARSE_OPT_NONEG, \ >> + parse_opt_merge_filter, (intptr_t) "HEAD" \ >> + } >> +#define OPT_MERGED(filter, h) \ >> + { OPTION_CALLBACK, 0, "merged", (filter), N_("commit"), (h), \ >> + PARSE_OPT_LASTARG_DEFAULT | PARSE_OPT_NONEG, \ >> + parse_opt_merge_filter, (intptr_t) "HEAD" \ >> + } > > Could you reduce the redundancy in these 2 macros? Yes, will do! -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html