On Fri, Jun 12, 2015 at 02:39:01PM -0700, Stefan Beller wrote:
> > - if (starts_with(buf, "PACK") || starts_with(buf + 1, "PACK")) {
> > + if (starts_with(buf, "PACK") || starts_with(buf, "\1PACK")) {
>
> This answers the question on the previous patch actually, maybe the
> code could be improved to
>
> if (is_sidechannel(out, ...)
> out++;
> if (starts_with(buf, "PACK") {
> ...
If it's not a PACK, then we don't want to skip past the side-channel
character (we show it as part of the trace).
Hopefully the end result after patch 3 reads well, as it sets an
explicit "sideband" flag.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html