Johannes Löthberg <johannes@xxxxxxxxxxxx> writes: > + if (get_git_namespace() && !symref.items) { > + die("git upload-pack: tried to clone from empty namespace"); > + } Is this sufficient? get_git_namespace() returns environment.c::namespace, which is set up in setup_git_env() by calling expand_namespace() and strlen() is run on that value, so I would presume the function will *ALWAYS* return true. Even when not namespaced, you would get an empty string "" whose address is not NULL, no? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html