Re: [PATCH/RFCv5 2/3] git rebase -i: warn about removed commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:
> Remi Galan Alfonso <remi.galan-alfonso@xxxxxxxxxxxxxxxxxxxxxxx> writes:
> 
> > Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:
> >> > +                        warn_file "$todo".miss
> >>
> >> I would find it more elegant with less intermediate files, like
> >>
> >> git rev-list $opt <"$todo".miss | while read -r line
> >> do
> >>         warn " - $line"
> >> done
> >
> > I am not really sure since I also use warn_file to display the bad
> > commands and SHA-1 in 3/3.
> 
> I noticed this later indeed. But had the function been eg. warn_pipe,
> you could have written
> 
> git rev-list $opt <"$todo".miss | warn_pipe

Interesting, I'll try to do something similar to this.

Rémi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]