On Wed, Jun 10, 2015 at 09:43:34AM +0700, Duy Nguyen wrote: > On Tue, Jun 9, 2015 at 10:00 PM, brian m. carlson > <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > You've increased this by 20, but you're adding 40 characters to the > > strcpy. Are you sure that's enough? > > > > Also, you might consider writing this in terms of GIT_SHA1_HEXSZ, as it > > will be more obvious that this depends on that value. If you don't now, > > I will later. > > It's a demonstration patch and I didn't pay much attention. I think > converting this quickref to strbuf may be better though, when you > convert this file to object_id. Yeah, I didn't realize until after the fact that it was only supposed to be a demo. I agree that strbuf might be a better idea. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: Digital signature