On 06/09/2015 01:02 AM, Junio C Hamano wrote:
Karthik Nayak <karthik.188@xxxxxxxxx> writes:+#define OPT_CONTAINS(filter, h) \ + { OPTION_CALLBACK, 0, "contains", (filter), N_("commit"), (h), \ + PARSE_OPT_LASTARG_DEFAULT, \ + parse_opt_with_commit, (intptr_t) "HEAD" \ + } +#define OPT_WITH(filter, h) \ + { OPTION_CALLBACK, 0, "with", (filter), N_("commit"), (h), \ + PARSE_OPT_LASTARG_DEFAULT, \ + parse_opt_with_commit, (intptr_t) "HEAD" \ + }The redundancy bothers me. Can't we do a bit better than that, perhaps like this? #define _OPT_CONTAINS_OR_WITH(name, variable, help) \ { OPTION_CALLBACK, 0, name, (variable), N_("commit"), (help), \ PARSE_OPT_LASTARG_DEFAULT, \ parse_opt_with_commit, (intptr_t) "HEAD" \ } #define OPT_CONTAINS(v, h) _OPT_CONTAINS_OR_WITH("contains", v, h)
This seems better, thanks! -- Regards, Karthik -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html