Antoine Delaite <antoine.delaite@xxxxxxxxxxxxxxxxxxxxxxx> writes:
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -32,6 +32,8 @@ OPTIONS_SPEC=
>
> _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
> _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
> +NAME_BAD="bad"
> +NAME_GOOD="good"
I would have written
NAME_NEW=bad
NAME_OLD=good
"old/new" are the generic wording, so I think it would make more sense
for the codebase to use it when we don't hardcode old/new.
(and the double-quotes are not needed)
> @@ -249,8 +254,8 @@ bisect_state() {
> bisect_write "$state" "$rev"
> done
> check_expected_revs $hash_list ;;
> - *,bad)
> - die "$(gettext "'git bisect bad' can take only one argument.")" ;;
> + *,"$NAME_BAD")
> + die "$(gettext "'git bisect $NAME_BAD' can take only one argument.")" ;;
As Junio mentionned, you'll need an eval_gettext here.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html