Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > Remi Lespinet <remi.lespinet@xxxxxxxxxxxxxxxxxxxxxxx> writes: > >> Simplify code by creating a function to transform list of email lists >> (comma separated, with aliases ...) into a simple list of valid email >> addresses. > > I would have found the series easier to read if this refactoring came > earlier (and then PATCH 2/5 would fix the bug as a positive side effect > of the refactoring). I agree that doing 5/5 sooner would make 4/5 a lot clearer. Introducing the helper of 5/5 before 2/5 happens, and then replacing two calls to validate-address-list with process-address-list would hide the nature of the change, i.e. fixing a bug, so it is better to see it done before the refactoring of 5/5, provided if it is indeed a bug that these were not expanded. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html