Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > Karthik Nayak <karthik.188@xxxxxxxxx> writes: > >> On 06/08/2015 08:23 PM, Matthieu Moy wrote: >>> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >>> >>> > +/* Free all memory allocated for ref_array */ >>> > +void ref_array_clear(struct ref_array *array) >>> >>> Is this a private function? If so, then add static. If not, you probably >>> want to export it in a .h file. >>> >> It is in ref-filter.h. > > Ah, OK. It comes later in the series. Confused I am; if it comes later not in the same patch then it is not OK, is it? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html