Re: [PATCH/RFC v2 5/5] send-email: refactor address list process

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Remi Lespinet <remi.lespinet@xxxxxxxxxxxxxxxxxxxxxxx> writes:

> Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:
>
>> Remi Lespinet <remi.lespinet@xxxxxxxxxxxxxxxxxxxxxxx> writes:
>> 
>> > Simplify code by creating a function to transform list of email lists
>> > (comma separated, with aliases ...)  into a simple list of valid email
>> > addresses.
>> 
>> I would have found the series easier to read if this refactoring came
>> earlier (and then PATCH 2/5 would fix the bug as a positive side effect
>> of the refactoring). I think it's too late to change this, though.
>
> Why is it to late? I can still change it if necessary.

To me, the series is ready now, and I don't think re-rolling it would be
a good time investment. Plus, I spent time reviewing this series and
with my proposal I'd need to review a relatively different one.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]